Support template-haskell and tests on GHC < 8.8 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can effortlessly support GHC 8.0+ instead of GHC 8.8+ for both building and testing, so let's do that. GHC's before 8.8 (base-4.13) don't export `MonadFail` to Prelude. Relax the bounds on `template-haskell` to support GHC 8.0+ Tighten the bounds on `containers` and `ansi-terminal` to exclude unsupported versions. Drop bounds specification in the test suite for dependencies shared with the library; the library already constrains these dependencies and it reduces maintenance burden.
martijnbastiaan
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can effortlessly support GHC 8.0+ instead of GHC 8.8+ for both building and testing, so let's do that.
GHC's before 8.8 (base-4.13) don't export
MonadFailto Prelude.Relax the bounds on
template-haskellto support GHC 8.0+Tighten the bounds on
containersandansi-terminalto exclude unsupported versions.Drop bounds specification in the test suite for dependencies shared with the library; the library already constrains these dependencies and it reduces maintenance burden.
This was tested with all major GHC versions between 8.0 and 9.0 inclusive, with
cabal v2-test {,--prefer-oldest}. I also checked the examples on GHC 8.0.To test with
--prefer-oldest, you'll need this incabal.project.localsince older versions of these packages do not build with GHC 8:We intend to add CI, but right now I'm focussing on getting this into Stackage. This is a preparation for that, just cleaning up some loose ends.