Repository navigation
fix: point default_code_formula_preset at a real Docling preset - #721
Merged
dolfim-ibm merged 1 commit intoOct 13, 2026
Merged
Conversation
The setting defaulted to the alias "default", which is not a Docling preset. docling-jobkit 3.8.0 resolves the code/formula preset whenever code or formula enrichment is enabled, so every such request failed with "Preset 'default' not found for CodeFormulaVlmOptions". Use granite_docling, the default docling-jobkit itself switched to. Signed-off-by: Ritankar Mondal <[email protected]>
Contributor
|
✅ DCO Check Passed Thanks @CyberRik, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #716.
Since v1.35.0, every conversion with
do_formula_enrichmentordo_code_enrichmentenabled fails while the pipeline is set up:Cause.
default_code_formula_presetdefaults to the alias"default". The converter manager maps thedefaultalias onto this setting, so it must name a real Docling preset. docling-jobkit 3.8.0 now resolves the code/formula preset whenever enrichment is enabled (before, only whencode_formula_presetwas given), so the bad default is hit on a stock deployment. docling-jobkit fixed its own default in docling-project/docling-jobkit#233, but docling-serve passes its setting through and overrides that fix.Change. The default is now
granite_docling, the same value docling-jobkit uses. The docs table and the default-value test are updated to match.Tests.
tests/test_default_presets.pybuilds the converter manager from_build_cm_config()with stock settings and checks thatdefaultresolves for every preset stage, and that a request with formula or code enrichment enabled resolves its options. Onmain, the three code/formula cases fail with theKeyErrorabove; with this change all pass.tests/test_env_parsing.pypasses.