Deliver root mail#952
Conversation
johansmitsnl
left a comment
johansmitsnl
left a comment
There was a problem hiding this comment.
Why do you need to update the email count with 2 if you only send one email during the test?
| @@ -1,2 +1,3 @@ | |||
| /^test[0-9][0-9]*@localhost.localdomain/ [email protected] | |||
| /^bounce.*@.*/ [email protected] | |||
| /^postmaster@/ [email protected] No newline at end of file | |||
There was a problem hiding this comment.
Can you add a new line.
There was a problem hiding this comment.
as I mentioned in the PR body, the tests are failing before my changes as the counts are already wrong - I assume some earlier change broke these tests.
|
The last test (PR #942) succeeded with the current count. Any idea where the second mail is coming from? (Bounce, fail, something like that?) |
|
You're right - I can't see any extra emails introduced in previous commits. When I comment out my extra mail in Makefile#252 then the build fails for me. Perhaps it's a test that was sending mail to postmaster@somewhere that was previously not delivered to any mailbox... |
|
OK - I think figured it out. The extra email is the virus notification email which is sent to postmaster and previously was not delivered. Now it is thanks to the extra config in |
|
So this was a bug? The mail was supposed to get delivered to postmaster? |
|
Well more like an undocumented / untested feature! If you configured your postmaster address to get delivered, then you would get the email. It's unrelated to this PR, which does fix a bug (the bug is that mail to root is not delivered, and no configuration could fix that). |
* Deliver root mail (Closes: #952) * don't update permissions on non-existent file (Closes: #956) * Update docker-configomat (Closes: #959) * Support for detecting running container mount (Closes: #884) * Report sender (Closes: #965) added REPORT_SENDER env variable to the container. * Add saslauthd option for ldap_start_tls & ldap_tls_check_peer - (Closes: #979, #980) * fix SASL domain (Closes: #892, #970) * DOMAINNAME can fail to be set in postsrsd-wrapper.sh (Closes: #989)
Release 6.1.0 * Deliver root mail (#952) * don't update permissions on non-existent file (#956) * Update docker-configomat (#959) * Support for detecting running container mount (#884) * Report sender (#965) added REPORT_SENDER env variable to the container. * Add saslauthd option for ldap_start_tls & ldap_tls_check_peer - (#979, #980) * fix SASL domain (#892, #970) * DOMAINNAME can fail to be set in postsrsd-wrapper.sh (#989)
3 participants
Deliver root mail to POSTMASTER_ADDRESS, fixes #947
If POSTMASTER_ADDRESS isn't defined, it defaults to [email protected], and so you can also get it delivered by creating a virtual alias for [email protected] or via my favoured approach of using a regexp alias for postmaster@* (as seen in the test config).
One other thing - the tests were already failing for me before my change, as the email counts had increased by one, hence why I am increasing them by two in this PR.