Password creation fix#914
Conversation
|
The same problem with the tests as on my side. They actually succeed rarely. I don't know why. There is no problem if I run the commands manually. |
|
|
||
| ./setup.sh -c mail alias del [email protected] [email protected] | ||
| run grep "[email protected]" ./config/postfix-virtual.cf | ||
| assert_failure |
There was a problem hiding this comment.
Why are these lines removed?
There was a problem hiding this comment.
Thanks for reviewing. I have no idea, I was working on too branches at the same time.
👍
|
Just to confirm, why is this file being removed? And why do the tests fail? |
|
Think this file gets deleted by make clean. There was another PR by @17Halbe last week adding this file after it gets deleted accidentially by the mail summary PR.. |
|
However I'm really not happy with those tests. They fail too frequently and I don't know why. Anyone got an idea? |
|
@17Halbe I restarted the job several times, do you know why it fails? |
|
\o/ But it‘s a dirty fix. It sleeps for 30(!) seconds for either of those two tests. :/ |
|
The sleep is needed indeed to allow the watcher to pickup the changed file. |
Release 6.0.0 * Implementation of multi-domain relay hosts (#922, #926) AWS_SES_HOST and AWS_SES_PORT are deprecated now. RELAY_HOST and RELAY_PORT are introduced to replace them. * Password creation fix (#908, #914) * Fixes 'duplicate log entry for /var/log/mail/mail.log' (#925, #927) * fixed cleanup (mail_with_relays didn't get cleaned up) (#930) * fix line breaks in postfix-summary mail error case (#936) * Set default virus delete time (#932, #935) This defaults to 7 days * Ensure that the account contains a @ (#923, #924) * Introducing global filters. (#934) * add missing env vars to docker-compose.yml (#937) * set postmaster address to a sensible default (#938, #939, #940)
3 participants
closes #908