Skip to content

test/config backup & restore#907

Merged
johansmitsnl merged 7 commits intodocker-mailserver:masterfrom
17Halbe:fix-config
Mar 21, 2018
Merged

test/config backup & restore#907
johansmitsnl merged 7 commits intodocker-mailserver:masterfrom
17Halbe:fix-config

Conversation

@17Halbe
Copy link
Copy Markdown
Contributor

@17Halbe 17Halbe commented Mar 18, 2018

Adapted the config folder backup strategy to the test folder.
Should be safer regarding future implementations.

@johansmitsnl
Copy link
Copy Markdown
Contributor

Test failed due to permission/missing files, could you verify this?

@17Halbe
Copy link
Copy Markdown
Contributor Author

17Halbe commented Mar 19, 2018

tests succeeded on my setup. I do run the tests as root though.
A conflict may occur if someone sets the repository up as a unprivileged user and then runs the tests as root.
In that case the config and test/config folders would change their ownership to root.
That being said. Why not preserving the ownership and permissions when copying?! ..Hold my beer! ;)

@17Halbe
Copy link
Copy Markdown
Contributor Author

17Halbe commented Mar 21, 2018

So I ended up introducing a backup rule. If the copy process is run during fixtures, some files appear to be locked and are unable of being read. fixtures wasn't the right place to do the backup anyway, since files already got modified till the backup(fixtures rule) happened.
Should have checked more thoroughly, and not rely on the copying being done on the right place and time. Sorry.

@johansmitsnl johansmitsnl merged commit a7589aa into docker-mailserver:master Mar 21, 2018
johansmitsnl added a commit that referenced this pull request Apr 1, 2018
Release 5.8.1

* add headers to postfix summary mail (#919)
* quotes needed to run multi-word command inside
  container (#921)
* Fix uncommented lines in .env file (#920)
* Tls level fix (#916)
* test/config backup & restore (#907)
* Restore userdb for tests (#913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants