Skip to content

Allow configuring SRS secrets using the environment#885

Merged
johansmitsnl merged 2 commits intodocker-mailserver:masterfrom
jamebus:srs-secret
Mar 8, 2018
Merged

Allow configuring SRS secrets using the environment#885
johansmitsnl merged 2 commits intodocker-mailserver:masterfrom
jamebus:srs-secret

Conversation

@jamebus
Copy link
Copy Markdown
Contributor

@jamebus jamebus commented Mar 8, 2018

It's a good idea to be able to specify SRS secrets.

  • If you're running a cluster, you'll need to have the same secret on each node to be able to accept DSNs consistently
  • Having a predictable secret baked into the image is bad for security. The secret is generated in the deb's postinst so you'll have a known secret for each build. That can be leveraged to create an open relay

Further work: I'll probably get another PR going to generate a secret and store it in state

@johansmitsnl johansmitsnl merged commit 2e8bb4a into docker-mailserver:master Mar 8, 2018
@jamebus jamebus deleted the srs-secret branch March 8, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants