Skip to content

Dkim key size#868

Merged
johansmitsnl merged 7 commits intodocker-mailserver:masterfrom
mwlczk:dkim-key-size
Mar 2, 2018
Merged

Dkim key size#868
johansmitsnl merged 7 commits intodocker-mailserver:masterfrom
mwlczk:dkim-key-size

Conversation

@mwlczk
Copy link
Copy Markdown
Contributor

@mwlczk mwlczk commented Feb 28, 2018

the keysize needs to be provided as the first parameter of the command generate-dkim-config
e.g.: generate-dkim-config 1024 for a 1024 key size
default (or left empty) is set to 2048.
Should help as a quick workaround for #855 and #786
cheers

@mwlczk
Copy link
Copy Markdown
Contributor Author

mwlczk commented Feb 28, 2018

If this is merged, need to update the wiki aswell
There is aswell the setup.sh wrapper for this which should be adjusted.
And tests are missing.

@johansmitsnl johansmitsnl merged commit c505177 into docker-mailserver:master Mar 2, 2018
@johansmitsnl johansmitsnl mentioned this pull request Mar 2, 2018
@mwlczk
Copy link
Copy Markdown
Contributor Author

mwlczk commented Mar 2, 2018

@johansmitsnl great job of closing all the issues, cudos.
I was implementing the TODOs i stated above, but got stuck at tests, because the bats-process is not allowed to read the dkim-keys (mail.txt). I am gonna use a less nice evaluation method of the size of the file instead of evaluating the key via openssl.
When I am done (soon hopefully) I push here again ;)

@mwlczk mwlczk mentioned this pull request Mar 3, 2018
polarathene pushed a commit to polarathene/docker-mailserver that referenced this pull request Feb 12, 2021
polarathene pushed a commit to polarathene/docker-mailserver that referenced this pull request Feb 22, 2021
polarathene pushed a commit to polarathene/docker-mailserver that referenced this pull request Feb 26, 2021
@polarathene polarathene mentioned this pull request Feb 5, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants