Integrate docker-configomat for configuration parts of start-mailserver.sh #648#650
Merged
alinmear merged 3 commits intodocker-mailserver:masterfrom Jul 9, 2017
Merged
Integrate docker-configomat for configuration parts of start-mailserver.sh #648#650alinmear merged 3 commits intodocker-mailserver:masterfrom
alinmear merged 3 commits intodocker-mailserver:masterfrom
Conversation
Contributor
Author
|
Hm, strange integration tests were just fine on my travis tests https://travis-ci.org/alinmear/docker-mailserver/builds/251575934. I will investigate this and fix this issue ... |
Contributor
Author
|
@tomav can you just restart the travis build please. I double checked this, locally and on my travis account. All good there. thx! |
Contributor
|
Restarted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr integrates my project https://github.com/alinmear/docker-configomat for dealing with container configurations via ENV Variables.
With this separate project testing whether substitution is working or not and also updating the logics behind them is much easier then doing this within
start-mailserver.sh(own travis and bats).This should also fix the problems with the special character
|from #644 (comment) (@johansmitsnl).