Thanks @alinmear

Thanks for this, I will try it out if I get a chance later this week

Thank you, I really didn't have the time to check the source to fix #591 so this mr will come in handy.

The new variable don't work because they are in comment. Why is this?
Now the dovecot variable don't work, so did not build a new image to test.

https://github.com/tomav/docker-mailserver/blob/21fb3f3c86391f079afb7fb59260b64019fa2e51/target/start-mailserver.sh#L593:L595

@johansmitsnl, these are only default values. If you want to change those values you need to set the corresponding ENV Variables, like:

- DOVECOT_PASS_FILTER="(&(objectClass=PostfixBookMailAccount)(uniqueIdentifier=%n))"
- DOVECOT_USER_FILTER="(&(objectClass=PostfixBookMailAccount)(uniqueIdentifier=%n))"

I already wrote an example within the readme.

Update1: I commented those defaults, because I am not sure, if this could lead to some unexpected behavior in some setups, if i set user and pass filter equal.

Update2: The main substitution is triggered by this call btw: override_config "DOVECOT_" "/etc/dovecot/dovecot-ldap.conf.ext"

Inside the docker:

echo $DOVECOT_PASS_FILTER
(&(objectClass=PostfixBookMailAccount)(|(uniqueIdentifier=%n)(mail=%u)))

cat /etc/dovecot/dovecot-ldap.conf.ext
pass_attrs          = uniqueIdentifier=user,userPassword=password
pass_filter         = (&(objectClass=PostfixBookMailAccount)(uniqueIdentifier=%n))
user_attrs          = mailHomeDirectory=home,mailUidNumber=uid,mailGidNumber=gid,mailStorageDirectory=mail
user_filter         = (&(objectClass=PostfixBookMailAccount)(uniqueIdentifier=%n))

It seems that the variables are not applied but they are set in the ENV.

@johansmitsnl , the problem here is the | within your expression; because we take the | for the separation of the sed parts; this is causing the problem; you could escape the | like:

(&(objectClass=PostfixBookMailAccount)(\|(uniqueIdentifier=%n)(mail=%u)))

This should work. I check how to deal with this kind of characters and sed, because currently we are doing the sed calls like:

sed -i -e "s|somethingelse|somethingelse-new|g"

Update: I found a solution by escaping the special character before the string is handed over to sed. I already made the commit within my project https://github.com/alinmear/docker-configomat and hopefully can merge this with the pr to #648.

@alinmear Escaping worked and solved my ldap issue #636.
It should only escape the special chars as you already noted.

Now we only have the #642 to rework to support virtual domains in the ldap. Will take a look how the changes where made and update the PR.