Support for modifying Postfix' master.cf#595
Conversation
tomav
left a comment
tomav
left a comment
There was a problem hiding this comment.
Could you add an integration test? Thanks.
* First pass at adding support for pipe and filter in Sieve, excluding unit tests. * Reduce insight into copied scripts * Added test * Adjustments related to switch to 16.04
…docker-mailserver#586 (docker-mailserver#612) * Fixes most of 2.3 issues reported in docker-mailserver#545 & 586
|
@MadsRC any update on this? Thank you. |
|
Time has been extremely short with an infant at home, so I haven't had the time to dig into the integration testing yet - That, and I'm not familiar with the bats framework. I'm not sure how much you want the test to cover? Reading the test file (Again, not familiar with bats, so I might be wrong) getting inspiration from the testing of main.cf I suppose a "postfix check" would cover much of it? |
|
Yep the same kind we used on main.cf |
|
@tomav - Added the integration test, and the build succeeds on my local machine when running "make". Seems like the build fails on travis, however, the unit test i made seem to have run fine? |
|
Thanks @MadsRC |
* Support for modifying Postfix' master.cf, using the syntax, in postfix-master.cf
5 participants
Support for modifying Postfix' master.cf, using the syntax, in postfix-master.cf
Fixes issue-594