Skip to content

#55 - added DKIM support -i 55#56

Merged
tomav merged 2 commits intodocker-mailserver:masterfrom
bilak:master
Jan 26, 2016
Merged

#55 - added DKIM support -i 55#56
tomav merged 2 commits intodocker-mailserver:masterfrom
bilak:master

Conversation

@bilak
Copy link
Copy Markdown
Contributor

@bilak bilak commented Jan 20, 2016

Added support for DKIM
Maybe something can be refactored, but it's working correctly now.

@tomav
Copy link
Copy Markdown
Contributor

tomav commented Jan 20, 2016

Thank you @bilak!

My questions:

  • does it work with multi-domains because I see a domainname ENV added to the project.
  • I'm not a DKIM expert but is there a way to add integration tests?

Thank you.

Comment thread postfix/TrustedHosts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line.

@bilak
Copy link
Copy Markdown
Contributor Author

bilak commented Jan 20, 2016

  • It's now working only for one domain. We can try to convert it to multi-domain in future, but there must be something with what we can decide there's more domains (maybe domainname values separated by comma)
  • About integration tests - only thing which we can check is information in log mail opendkim[579]: 359D4A1245: DKIM-Signature field added (s=mail, d=domain.com). I don't know much about postfix neither about docker so your help will be needed.

@tomav
Copy link
Copy Markdown
Contributor

tomav commented Jan 20, 2016

@bilak
Copy link
Copy Markdown
Contributor Author

bilak commented Jan 20, 2016

  • So if I understand it correctly, there could be function created from my script which will accept only domain name (think about how to check duplicated processing - for example ten users with same domain and another 10 users with another domain). There's need to create (if not exists) DKIM (privatet, txt), add entry to KeyTab and to SigningTable.

@tomav
Copy link
Copy Markdown
Contributor

tomav commented Jan 20, 2016

The postfix/vhost file is generated by startup script and contains unique domains.
I think you can use this file as reference and paste your DKIM startup lines after its generation.

The point is, for these domains, enable DKIM if necessary information are provided.

tomav added a commit that referenced this pull request Jan 26, 2016
#55 - added DKIM support -i 55
@tomav tomav merged commit 06281f7 into docker-mailserver:master Jan 26, 2016
@tomav
Copy link
Copy Markdown
Contributor

tomav commented Jan 26, 2016

Thank you @bilak

tomav added a commit that referenced this pull request Jan 26, 2016
@polarathene polarathene mentioned this pull request Feb 5, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants