Skip to content

Added greylisting using postgrey#495

Merged
tomav merged 4 commits intodocker-mailserver:masterfrom
adrl-sven-kauber:issue-255
Feb 6, 2017
Merged

Added greylisting using postgrey#495
tomav merged 4 commits intodocker-mailserver:masterfrom
adrl-sven-kauber:issue-255

Conversation

@adrl-sven-kauber
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@tomav tomav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect! Thanks for this good job.
Seen comments below.

Comment thread target/postgrey/postgrey.init Outdated
;;
esac

exit $ret No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

Comment thread target/postgrey/postgrey Outdated

POSTGREY_OPTS="--inet=10023"

#POSTGREY_TEXT="Your customized rejection message here" No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

Comment thread test/tests.bats
run docker exec mail_with_postgrey /bin/bash -c "ps aux --forest | grep -v grep | grep '/usr/sbin/postgrey'"
assert_success
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test on Postgrey behaviour on incoming mail?

…ed the issue of non-unlinkable daemon pid, ensured that configuration changes are not duplicated, updated some tests and added two new ones
@adrl-sven-kauber
Copy link
Copy Markdown
Contributor Author

These new edits are now complete:

  • added the missing newlines
  • added the support for new parameters: POSTGREY_DELAY, POSTGREY_MAX_AGE, POSTGREY_TEXT
  • fixed the issue of non-unlinkable pid when the daemon is stopped, modified the custom init script accordingly
  • ensured that the configuration changes are not duplicated on container restart
  • updated the tests to support the new parameters
  • added two new tests using netcat to ensure that postgrey functions properly

@tomav
Copy link
Copy Markdown
Contributor

tomav commented Feb 3, 2017

Restarted build.

@tomav tomav merged commit c7e4206 into docker-mailserver:master Feb 6, 2017
@tomav
Copy link
Copy Markdown
Contributor

tomav commented Feb 6, 2017

Thanks you @5VEN!

@adrl-sven-kauber adrl-sven-kauber deleted the issue-255 branch February 6, 2017 10:19
@adrl-sven-kauber
Copy link
Copy Markdown
Contributor Author

@tomav, you're welcome! This greylisting seems quite useful. I received about 10 spam messages each day to two email addresses but now after setting POSTGREY_DELAY to 3600, the amount of spam went down to 1-2 per day.

RichardFevrier pushed a commit to RichardFevrier/docker-mailserver that referenced this pull request Aug 26, 2019
* Added greylisting using postgrey
* Updated the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants