fix: packages.sh - Remove Postfix hostname workaround#4493
Merged
georglauterbach merged 3 commits intomasterfrom May 27, 2025
Merged
fix: packages.sh - Remove Postfix hostname workaround#4493georglauterbach merged 3 commits intomasterfrom
packages.sh - Remove Postfix hostname workaround#4493georglauterbach merged 3 commits intomasterfrom
Conversation
polarathene
added
service/postfix
area/scripts
kind/improvement
polarathene
requested review from
casperklein and
georglauterbach
and removed request for
casperklein
polarathene
changed the title
packages.sh - Revise Postfix hostname workaroundpackages.sh - Remove Postfix hostname workaround
polarathene
changed the title
packages.sh - Remove Postfix hostname workaroundpackages.sh - Remove Postfix hostname workaround
georglauterbach
approved these changes
May 27, 2025
Member
georglauterbach
left a comment
georglauterbach
left a comment
There was a problem hiding this comment.
A very welcome change!
casperklein
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This workaround can be dropped :)
The original issue report workaround we presently use, and the verified alternative workaround (via buildx arg) are no longer appear required since upstream commits (1 + 2) in late 2021 have patched the logic in the Debian Postfix package post-install script 🎉
Original PR
UPDATE: The first commit of this PR was prior to checking the status of the Debian package, so a follow-up commit removes those changes as they're no longer needed 😎
@casperklein spotted an issue with the original workaround that the initial commit of this PR resolves, although it never caused a problem as without a shebang the existing shell itself was used (I've verified).
References:
Type of change
Checklist
CHANGELOG.md