fix: Ensure DMS config volume can be accessed by non-root users#4487
Merged
polarathene merged 3 commits intomasterfrom May 23, 2025
Merged
fix: Ensure DMS config volume can be accessed by non-root users#4487polarathene merged 3 commits intomasterfrom
polarathene merged 3 commits intomasterfrom
Conversation
Member
Author
|
I've added a separate |
1 task
casperklein
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is similar to a recent fix for the DMS state volume, where a non-root user needs access but the host directory mounted has mistakenly been too aggressive with permissions for the directory (one known example is AWS ECS (EC2) using EBS volumes).
It appears that Rspamd support with DKIM at least expects this due to running operations as the
_rspamduser to read content from the DMS config volume. In future this concern shouldn't be the case, as the root user during setup could make internal copies that anything running as_rspamdshould instead interact with.However since this is not always an obvious failure (various unresolved reports in the past were tripped up by this for the state volume), the fix is probably worth adding? (makes me wonder if similar is prone to our other volumes too then 🤔)
NOTE: While we only need
chmod o+x, we can usechmod +xhere as unlike other permissions like+wit appears to apply+xtougoby default.Fixes: #4485
Type of change
Checklist
CHANGELOG.md