-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: setup email list should only work with ACCOUNT_PROVISIONER=FILE
#4453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
polarathene
merged 8 commits into
master
from
fix/setup-cli-email-list-add-compat-error
Apr 24, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
54bb7d3
fix: `setup email list` should only work with `ACCOUNT_PROVISIONER=FILE`
polarathene 5e917d4
chore: Avoid `ENABLE_QUOTAS=1` default when not supported by config
polarathene b8b2ab6
chore: Add CHANGELOG entry
polarathene ffab7af
lint: Fix bash operator
polarathene db319d8
Update CHANGELOG.md
polarathene 503072e
Merge branch 'master' into fix/setup-cli-email-list-add-compat-error
georglauterbach 168856d
Update target/scripts/startup/variables-stack.sh
polarathene a871a58
fix: move ENV setup to location where other variables are already set
georglauterbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could technically be dropped, but I don't think DMS is intended to support both file based accounts and LDAP at the same time, so I'm inclined to keep the early exit constraint here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fail-fast is the right approach here, indeed.