fix: setup email list should only work with ACCOUNT_PROVISIONER=FILE#4453
Merged
polarathene merged 8 commits intomasterfrom Apr 24, 2025
Merged
fix: setup email list should only work with ACCOUNT_PROVISIONER=FILE#4453polarathene merged 8 commits intomasterfrom
setup email list should only work with ACCOUNT_PROVISIONER=FILE#4453polarathene merged 8 commits intomasterfrom
Conversation
polarathene
added
service/dovecot
area/scripts
kind/improvement
polarathene
commented
Apr 23, 2025
polarathene
commented
Apr 23, 2025
Comment on lines
+11
to
+13
| if [[ ${ACCOUNT_PROVISIONER} != 'FILE' ]]; then | ||
| _exit_with_error "This command is only compatible with 'ACCOUNT_PROVISIONER=FILE'" | ||
| fi |
Member
Author
There was a problem hiding this comment.
This could technically be dropped, but I don't think DMS is intended to support both file based accounts and LDAP at the same time, so I'm inclined to keep the early exit constraint here? 🤔
Member
There was a problem hiding this comment.
Fail-fast is the right approach here, indeed.
georglauterbach
approved these changes
Apr 23, 2025
georglauterbach
requested changes
Apr 23, 2025
Co-authored-by: Georg Lauterbach <[email protected]>
Signed-off-by: Georg Lauterbach <[email protected]>
Member
|
I pushed a fix for the still-occurring test failure. Hope the issue is now fixed. |
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: a871a58 |
georglauterbach
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses https://github.com/orgs/docker-mailserver/discussions/4452#discussioncomment-12918479
It should provide a better UX than a bunch of unhelpful errors like the user experienced.
Type of change
Checklist
CHANGELOG.md