Skip to content

fix: revert __declare_readonly overcomplication#4372

Merged
georglauterbach merged 3 commits intomasterfrom
gl/revert-readonly
Feb 17, 2025
Merged

fix: revert __declare_readonly overcomplication#4372
georglauterbach merged 3 commits intomasterfrom
gl/revert-readonly

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Feb 16, 2025

Description

Removes __declare_readonly again which was introduced in #4323.

Fixes #4323 (comment)

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach georglauterbach added priority/medium area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Feb 16, 2025
@georglauterbach georglauterbach added this to the v15.0.0 milestone Feb 16, 2025
@georglauterbach georglauterbach self-assigned this Feb 16, 2025
@georglauterbach georglauterbach mentioned this pull request Feb 16, 2025
Merged
9 tasks
@casperklein
Copy link
Copy Markdown
Member

casperklein commented Feb 16, 2025

The two tests, if DMS_STATE_DIR is not set can be removed too: ${DMS_STATE_DIR:?DMS_STATE_DIR is not set} in line 6 & 94

polarathene
polarathene previously approved these changes Feb 16, 2025
View reviewed changes
@georglauterbach
chore: remove redundant checks
8b01330 
Signed-off-by: Georg Lauterbach <[email protected]>
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Feb 16, 2025

I removed the redundant checks and set this PR to auto-merge.

@georglauterbach georglauterbach enabled auto-merge (squash) February 16, 2025 22:14
@georglauterbach georglauterbach merged commit 0294294 into master Feb 17, 2025
@georglauterbach georglauterbach deleted the gl/revert-readonly branch February 17, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@casperklein casperklein Awaiting requested review from casperklein

Assignees

@georglauterbach georglauterbach

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/medium

Projects

None yet

Milestone

v15.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@georglauterbach @casperklein @polarathene