chore: remove VERSION file#4321
Merged
georglauterbach merged 3 commits intomasterfrom Jan 19, 2025
Merged
Conversation
Signed-off-by: georglauterbach <[email protected]>
georglauterbach
added
priority/medium
area/configuration (file)
kind/update
Member
Author
|
GitHub does not seem to run the CI against the merged changes, hence CI fails. I can merge with administrator privileges if you think these changes are fine @casperklein @polarathene. |
polarathene
previously approved these changes
Jan 18, 2025
Member
polarathene
left a comment
polarathene
left a comment
There was a problem hiding this comment.
GitHub does not seem to run the CI against the merged changes, hence CI fails.
Yeah we have the CI workflow pointing at the latest master branch commit for reusable workflows like the image build or tests (it's only the workflow part, they'll use the PR branch for building/testing).
LGTM! 👍
casperklein
reviewed
Jan 18, 2025
Co-authored-by: Casper <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3677
ref #4302
Type of change
Checklist
docs/)CHANGELOG.md