Conversation
Contributor
|
Great improvement, thanks for your work @tomav! I'm wondering if this change needs to introduce a new major version an in my current view it should. The reason is that the new variable names are not backwards-compatible, so those who do docker pull for v2 will encounter issues. How about giving the new release v3? |
Contributor
Author
|
Hi @kachkaev, you're right, that's why I released a 2.1 (removed the |
Contributor
Author
|
There's still a |
RichardFevrier
pushed a commit
to RichardFevrier/docker-mailserver
that referenced
this pull request
Aug 26, 2019
* Removed DISABLE_AMAVIS * Renamed DISABLE_* to ENABLE_* with 0 as default value. (this must be explicit) * Added missing tests for ENABLE_* * Improved readme and docker-compose example Should fix docker-mailserver#256 and docker-mailserver#386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #256 and #386
This will be released as
tvial/docker-mailserver:2.1