ci(docs-preview): Refactor workflows#4262
Merged
polarathene merged 3 commits intomasterfrom Nov 15, 2024
Merged
Conversation
polarathene
commented
Nov 14, 2024
This was referenced Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored and better documented our CI workflows for generating documentation previews.
This PR needs to be merged before a follow-up which proposes to move away from the current
pull_request+workflow_runapproach that presently is not compatible with PRs from forks.TL;DR: Overall, it's mostly shuffling stuff around, added comments and minor improvements. I wanted to keep the noise of these changes separate from the follow-up PR which will get a proper review process.
Overview of changes:
build-docs.shis now grouped in the steps action log, and now hides the noise from pulling the image viadocker run.tarsteps with ZSTD:pr.env). Theupload+downloadactions are sufficient enough for a zip archive.dawidd6/action-download-artifactwas used becauseactions/download-artifactdid not support retrieving the workflow.workflow_runjob has had the PR context restore step extracted to a separate job to minimize noise.actions-netlifyis still effectively the same functionality.github-tokenis no longer configured as it doesn't appear needed with the functions disabled.NOTE: The current
workflow_run(master) is expected to fail due to thepull_request(prepare) workflow running from this PR instead of themasterbranch version of the workflow. Failure is due to change in artifact upload/download.Type of change
Checklist