Skip to content

ci(docs-preview): Refactor workflows#4262

Merged
polarathene merged 3 commits intomasterfrom
ci/docs-preview-refactor
Nov 15, 2024
Merged

ci(docs-preview): Refactor workflows#4262
polarathene merged 3 commits intomasterfrom
ci/docs-preview-refactor

Conversation

@polarathene
Copy link
Copy Markdown
Member

@polarathene polarathene commented Nov 14, 2024

Description

Refactored and better documented our CI workflows for generating documentation previews.

This PR needs to be merged before a follow-up which proposes to move away from the current pull_request + workflow_run approach that presently is not compatible with PRs from forks.

  • If you would like to block and provide a review but lack time to do so within the next 24 hours, let me know otherwise I'm not expecting much feedback here and will merge without approval.
  • I have ensured this change works as intended by testing via a separate repo of my own.

TL;DR: Overall, it's mostly shuffling stuff around, added comments and minor improvements. I wanted to keep the noise of these changes separate from the follow-up PR which will get a proper review process.

Overview of changes:

  • Runner bumped from Ubuntu 22.04 => 24.04
  • Revised inline documentation for maintainers.
  • The output of build-docs.sh is now grouped in the steps action log, and now hides the noise from pulling the image via docker run.
  • Removed the separate tar steps with ZSTD:
  • The workflow_run job has had the PR context restore step extracted to a separate job to minimize noise.
  • actions-netlify is still effectively the same functionality.
    • github-token is no longer configured as it doesn't appear needed with the functions disabled.
    • Opt-out of the GH deployments feature which is not needed.

NOTE: The current workflow_run (master) is expected to fail due to the pull_request (prepare) workflow running from this PR instead of the master branch version of the workflow. Failure is due to change in artifact upload/download.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@polarathene polarathene self-assigned this Nov 14, 2024
@polarathene polarathene added area/ci priority/high kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Nov 14, 2024
@polarathene polarathene added this to the v15.0.0 milestone Nov 14, 2024
Comment thread .github/workflows/docs-preview-deploy.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci area/documentation kind/improvement Improve an existing feature, configuration file or the documentation priority/high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant