Skip to content

docs(fix): SMTP bind example show snippet titles#4258

Closed
polarathene wants to merge 2 commits intomasterfrom
docs/smtp-bind-fix-snippet-titles
Closed

docs(fix): SMTP bind example show snippet titles#4258
polarathene wants to merge 2 commits intomasterfrom
docs/smtp-bind-fix-snippet-titles

Conversation

@polarathene
Copy link
Copy Markdown
Member

Description

Fixes a syntax issue that broke rendering of these snippets.

@polarathene polarathene self-assigned this Nov 10, 2024
@polarathene polarathene added area/documentation service/postfix kind/improvement Improve an existing feature, configuration file or the documentation labels Nov 10, 2024
@polarathene polarathene added this to the v15.0.0 milestone Nov 10, 2024
@polarathene
Copy link
Copy Markdown
Member Author

that broke rendering of these snippets.

What exactly is broken in the snippets? They are rendering fine for me.

I've only noticed it on :edge a month or so ago, yet the docs page and docker docs builder image haven't been modified since 10 months ago with v14. So unless it's a regression of the 9.5 point releases of mkdocs-material, perhaps it was introduced somewhere else 🤷‍♂️

image

I could try bumping the docs builder image (EDIT: Nope, no new minor, it's at 9.5.44 now, so probably a regression).


Not related, but I think that could be useful additions:

Yeah, we could add the copy button. Some time it's been annoying when I've seen it in docs due to the button overlay covering up text visibility when you just want to read the actual content (that was a bit too long/wide). Feel free to PR it :)

The line selection feature you linked we cannot use for now as it's insiders members only.

@casperklein
Copy link
Copy Markdown
Member

I've only noticed it on :edge

Confirmed 👍

@polarathene
Copy link
Copy Markdown
Member Author

polarathene commented Nov 12, 2024

This PR won't be necessary to fix.

It turns out we've not had a build since Sep 29 which was just bad timing with the regression which has since been fixed: squidfunk/mkdocs-material#7687 (reply in thread)

EDIT: Resolved and verified by:

@polarathene polarathene removed this from the v15.0.0 milestone Nov 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 884bb90

@polarathene
Copy link
Copy Markdown
Member Author

Closing as verified this is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation service/postfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants