Skip to content

docs: update CONTRIBUTORS.md#4139

Merged
georglauterbach merged 1 commit intomasterfrom
contributors-readme-action-GQ71osmdPG
Jul 30, 2024
Merged

docs: update CONTRIBUTORS.md#4139
georglauterbach merged 1 commit intomasterfrom
contributors-readme-action-GQ71osmdPG

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

No description provided.

@polarathene
Copy link
Copy Markdown
Member

I've been wondering what the value add is from this automation/feature? Previously it was with some additional context like the type of contribution but now it's just a list which Github already maintains?

image

It does only show the top 100 contributors, but anyone with 3 commits to the repo would be on there:

image


I'm fine keeping it, but I don't know if there's any actual reason for it given the project size. If you have below 3 commits, you can probably link to those directly.

This file just says that users contributed to the project, no additional context. If you know the username you can use the search bar for issues/PR activity for example.

If no active maintainer sees value in it, then these automated PRs are just noise? (I don't recall it's introduction having any user demand for it)

@georglauterbach georglauterbach merged commit c544d77 into master Jul 30, 2024
@georglauterbach georglauterbach deleted the contributors-readme-action-GQ71osmdPG branch July 30, 2024 16:34
@georglauterbach
Copy link
Copy Markdown
Member

We can remove it, I agree with @polarathene on this one. What's your opinion @casperklein?

@casperklein casperklein mentioned this pull request Jul 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants