Skip to content

chore: Prevent Microsoft MUAs from sending reactions#4120

Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom
mpldr-pulls:patch-1
Jul 22, 2024
Merged

chore: Prevent Microsoft MUAs from sending reactions#4120
polarathene merged 2 commits intodocker-mailserver:masterfrom
mpldr-pulls:patch-1

Conversation

@mpldr
Copy link
Copy Markdown
Contributor

@mpldr mpldr commented Jul 18, 2024 •
edited
Loading

Description

Microsoft added a way to "react" to emails which is turned into

[Image] liked this message.

No MUA except Microsoft's latest ones displays these properly and they are not providing significant value to an Email-exchange.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

polarathene
polarathene requested changes Jul 19, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
@georglauterbach georglauterbach added service/postfix kind/improvement Improve an existing feature, configuration file or the documentation area/configuration (file) labels Jul 21, 2024
@georglauterbach georglauterbach added this to the v14.1.0 milestone Jul 21, 2024
casperklein
casperklein previously approved these changes Jul 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ambivalent about this PR. Personally I don't like that MS feature. But I am also not a fan of including app specific hacks into DMS.

For me, it would be fine to do such things via user-patches.sh.

@mpldr
Copy link
Copy Markdown
Contributor Author

mpldr commented Jul 21, 2024

But I am also not a fan of including app specific hacks into DMS.

Me neither, but if a multi-billion dollar corporation feels like undermining standards, we – as in people invested in keeping the technology open and accessible – should make sure that this does not work with our systems. Google pulled something similar with XMPP and I would find it sad, if Microsoft did it to Email.

polarathene
polarathene previously approved these changes Jul 21, 2024
View reviewed changes
@polarathene
Copy link
Copy Markdown
Member

polarathene commented Jul 21, 2024

We do not have the permission to rebase or merge master to update your branch, you'll need to update your branch again. Conflict would be from a recent PR that updated the CHANGELOG.md.

If the PR here doesn't cause any issues for users (I don't know if it makes sense to expect the feature compatibility with DMS), merging is fine. Otherwise I'd agree with @casperklein and just add a tip in our docs about it with user-patches.sh.

mpldr added 2 commits July 22, 2024 12:37
@mpldr
Prevent Microsoft MUAs from sending reactions
76a28f9 
No one in their right mind would want this, so we can probably just drop it.
@mpldr
Update CHANGELOG.md
c75cac4 
Signed-off-by: Moritz Poldrack <[email protected]>
@mpldr mpldr dismissed stale reviews from polarathene and casperklein via c75cac4 July 22, 2024 10:38
@polarathene polarathene changed the title Prevent Microsoft MUAs from sending reactions chore: Prevent Microsoft MUAs from sending reactions Jul 22, 2024
@polarathene polarathene merged commit 009237c into docker-mailserver:master Jul 22, 2024
@georglauterbach georglauterbach modified the milestones: v14.1.0, v15.0.0 Sep 26, 2024
mpldr added a commit to mpldr-pulls/docker-mailserver that referenced this pull request Mar 23, 2025
@mpldr
fix: ensure message content is not modified by header filter
1f07f39 
Due to an oversight, one of the header filters has potentially modified
the message body, leading to broken cryptographic signatures.

Switch to the Message-Id instead of the Content-Type header, which is
usually only present in the global header.

Signed-off-by: Moritz Poldrack <[email protected]>
Reported-by: Cole Young <[email protected]>
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (docker-mailserver#4120)")
@mpldr mpldr mentioned this pull request Mar 23, 2025
Closed
mpldr added a commit to mpldr-pulls/docker-mailserver that referenced this pull request Mar 24, 2025
@mpldr @georglauterbach
fix: ensure message content is not modified by header filter
dd33fb5 
Due to an oversight, one of the header filters has potentially modified
the message body, leading to broken cryptographic signatures.

Switch to the Message-Id instead of the Content-Type header, which is
usually only present in the global header.

Signed-off-by: Moritz Poldrack <[email protected]>
Co-Authored-by: Georg Lauterbach <[email protected]>
Reported-by: Cole Young <[email protected]>
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (docker-mailserver#4120)")
@mpldr mpldr mentioned this pull request Mar 24, 2025
Merged
mpldr added a commit to mpldr-pulls/docker-mailserver that referenced this pull request Mar 25, 2025
@mpldr @georglauterbach
fix: ensure message content is not modified by header filter
e713cb5 
Due to an oversight, one of the header filters has potentially modified
the message body, leading to broken cryptographic signatures.

Switch to the Message-Id instead of the Content-Type header, which is
usually only present in the global header.

Signed-off-by: Moritz Poldrack <[email protected]>
Co-Authored-by: Georg Lauterbach <[email protected]>
Reported-by: Cole Young <[email protected]>
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (docker-mailserver#4120)")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@casperklein casperklein casperklein left review comments

Assignees

@mpldr mpldr

Labels

area/configuration (file) kind/improvement Improve an existing feature, configuration file or the documentation service/postfix

Projects

None yet

Milestone

v15.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mpldr @polarathene @casperklein @georglauterbach