Skip to content

tests: Update curl note for XOAUTH2 support#4118

Merged
polarathene merged 1 commit intomasterfrom
tests/xoauth2-curl-min-version-needed
Jul 17, 2024
Merged

tests: Update curl note for XOAUTH2 support#4118
polarathene merged 1 commit intomasterfrom
tests/xoauth2-curl-min-version-needed

Conversation

@polarathene
Copy link
Copy Markdown
Member

@polarathene polarathene commented Jul 17, 2024

Description

The test case will not be able to run until Debian provides a release of curl from 2024. Better visibility and references documented for maintenance.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

@polarathene polarathene added area/tests kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Jul 17, 2024
@polarathene polarathene added this to the v14.1.0 milestone Jul 17, 2024
@polarathene polarathene self-assigned this Jul 17, 2024
@polarathene
Copy link
Copy Markdown
Member Author

polarathene commented Jul 17, 2024 •
edited
Loading

I could raise an issue about for resolving this but I doubt it'll ever be a concern out of tests.

Instead the setup_cli.bats test should probably be relocated into the serial group instead of parallel, that way the test shouldn't fail due to race condition 👍

Unexpected test failure:

not ok 74 [setup.sh] show usage when no arguments provided in 107ms
# (from function `assert_success' in file test/test_helper/bats-assert/src/assert_success.bash, line 42,
#  in test file test/tests/parallel/set3/scripts/setup_cli.bats, line 30)
#   `assert_success' failed
#
# -- command failed --
# status : 1
# output : Error response from daemon: No such container: dms-test_postconf-helper
# --
#

docker-mailserver/test/tests/parallel/set3/scripts/setup_cli.bats

Line 6 in 34423c2

CONTAINER_NAME='dms-test_setup-cli'

docker-mailserver/test/tests/parallel/set3/scripts/setup_cli.bats

Lines 28 to 32 in 34423c2

@test "show usage when no arguments provided" {
run ./setup.sh
assert_success
assert_output --partial "This is the main administration command that you use for all your interactions with"
}

It seems the setup.sh script being called accidentally found a DMS container from another test (running concurrently), instead of the container belonging to the setup_cli.bats tests? (they're both in the same parallel test group):

docker-mailserver/test/tests/parallel/set3/scripts/postconf-helper.bats

Line 5 in 34423c2

CONTAINER_NAME='dms-test_postconf-helper'

Probably due to CONTAINER_NAME usage in setup.sh:

docker-mailserver/setup.sh

Lines 169 to 172 in 34423c2

INFO=$(${CRI} ps --no-trunc --format "{{.Image}};{{.Names}}" --filter \
label=org.opencontainers.image.title="docker-mailserver" | tail -1)
[[ -z ${CONTAINER_NAME} ]] && CONTAINER_NAME=${INFO#*;}

docker-mailserver/setup.sh

Line 187 in 34423c2

_handle_config_path

docker-mailserver/setup.sh

Lines 89 to 96 in 34423c2

function _handle_config_path() {
if [[ -z ${DESIRED_CONFIG_PATH} ]]; then
# no desired config path
if [[ -n ${CONTAINER_NAME} ]]; then
VOLUME=$(${CRI} inspect "${CONTAINER_NAME}" \
--format="{{range .Mounts}}{{ println .Source .Destination}}{{end}}" | \
grep "${DMS_CONFIG}$" 2>/dev/null || :)
fi

docker-mailserver/setup.sh

Lines 189 to 193 in 34423c2

if [[ -n ${CONTAINER_NAME} ]]; then
${CRI} exec "${USE_TTY}" "${CONTAINER_NAME}" setup "${@}"
else
_run_in_new_container setup "${@}"
fi

@polarathene polarathene merged commit c5f125c into master Jul 17, 2024
@polarathene polarathene deleted the tests/xoauth2-curl-min-version-needed branch July 17, 2024 22:31
@polarathene polarathene mentioned this pull request Aug 2, 2024
Open
60 tasks
@georglauterbach georglauterbach modified the milestones: v14.1.0, v15.0.0 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@georglauterbach georglauterbach Awaiting requested review from georglauterbach

Assignees

@polarathene polarathene

Labels

area/documentation area/tests kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v15.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@polarathene @casperklein @georglauterbach