Skip to content

docs(k8s): Advise externalTrafficPolicy: Local if no PROXY protocol configured#4039

Merged
polarathene merged 3 commits intodocker-mailserver:masterfrom
Amphaal:patch-1
May 28, 2024
Merged

docs(k8s): Advise externalTrafficPolicy: Local if no PROXY protocol configured#4039
polarathene merged 3 commits intodocker-mailserver:masterfrom
Amphaal:patch-1

Conversation

@Amphaal
Copy link
Copy Markdown
Contributor

@Amphaal Amphaal commented May 27, 2024

If not using externalTrafficPolicy: Local in service declaration, all incoming requests will most likely be branded as proxied by the externalIp by which the mail services are accessed; this is undesired. As a side effect, any externalIp will eventually get banned by Fail2Ban, which helped my diagnosis this misconfiguration.

I have no idea how well this enforced parameter plays along with "PROXY protocol" configuration.

Comment thread docs/content/config/advanced/kubernetes.md Outdated
Comment thread docs/content/config/advanced/kubernetes.md Outdated
@georglauterbach
Copy link
Copy Markdown
Member

This is a welcome contribution, and something I missed. externalTrafficPolicy with Local is correct; with PROXY protocol it does not matter though. I think the comment from @polarathene makes that clear. I am fine with the change here.

@georglauterbach georglauterbach enabled auto-merge (squash) May 28, 2024 11:12
@Amphaal
Copy link
Copy Markdown
Contributor Author

Amphaal commented May 28, 2024

LGTM, thanks guys !

@polarathene polarathene changed the title [Kubernetes docs] Fix service declaration docs(k8s): Advise externalTrafficPolicy: Local if no PROXY protocol configured May 28, 2024
@polarathene polarathene disabled auto-merge May 28, 2024 15:51
@polarathene polarathene enabled auto-merge (squash) May 28, 2024 15:52
@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 6090329

@polarathene polarathene merged commit 95d965f into docker-mailserver:master May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants