Skip to content

docs: Revise fetchmail page#3998

Merged
polarathene merged 6 commits intomasterfrom
docs/fetchmail-troubleshooting-example
May 2, 2024
Merged

docs: Revise fetchmail page#3998
polarathene merged 6 commits intomasterfrom
docs/fetchmail-troubleshooting-example

Conversation

@polarathene
Copy link
Copy Markdown
Member

@polarathene polarathene commented May 2, 2024 •
edited
Loading

Description

Docs preview link: https://pullrequest-3998--dms-doc-previews.netlify.app/config/advanced/mail-fetchmail/

  • Some minor adjustments to the existing fetchmail docs content (shifted into admonitions). (EDIT: Committed various revisions)
  • Included a link to a recent discussion, providing a reference to a full compose.yaml setup to troubleshoot fetchmail locally with two DMS instances.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@polarathene polarathene added this to the v14.0.0 milestone May 2, 2024
@polarathene polarathene self-assigned this May 2, 2024
@polarathene polarathene changed the title docs: Add reference to fetchmail compose.yaml example docs: Revise fetchmail page May 2, 2024
georglauterbach
georglauterbach approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borderline ok with the amount of (nested) admonitions 😂☺️ LGTM 👍🏼

@polarathene
Copy link
Copy Markdown
Member Author

polarathene commented May 2, 2024

Borderline ok with the amount of (nested) admonitions

If someone can present the information better I'm all for it! 😂

On the bright side, we now have a metric to gage if a docs page has been neglected 😎

@polarathene polarathene enabled auto-merge (squash) May 2, 2024 07:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2024

Documentation preview for this PR is ready! 🎉

Built with commit: 46a7c20

@polarathene polarathene merged commit d00edd7 into master May 2, 2024
@polarathene polarathene deleted the docs/fetchmail-troubleshooting-example branch May 2, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georglauterbach georglauterbach georglauterbach approved these changes

@casperklein casperklein Awaiting requested review from casperklein

Assignees

@polarathene polarathene

Labels

area/documentation service/fetchmail

Projects

None yet

Milestone

v14.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@polarathene @georglauterbach