Skip to content

Enable spamassassin only, when amavis is enabled too.#3943

Merged
casperklein merged 5 commits intodocker-mailserver:masterfrom
casperklein:amavis-sa
Mar 20, 2024
Merged

Enable spamassassin only, when amavis is enabled too.#3943
casperklein merged 5 commits intodocker-mailserver:masterfrom
casperklein:amavis-sa

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Mar 16, 2024 •
edited
Loading

Description

Fixes #3569

@georglauterbach Please check the two commits. Which one do you prefer? Related: #3323 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@casperklein casperklein self-assigned this Mar 16, 2024
@casperklein casperklein added area/scripts kind/bug/fix A fix (PR) for a confirmed bug labels Mar 16, 2024
@casperklein casperklein added this to the v14.0.0 milestone Mar 16, 2024
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Mar 16, 2024 •
edited
Loading

@georglauterbach Please check the two commits. Which one do you prefer? Related: #3323 (comment)

Since we don't provide an ENV to easily integrate spamassassin in rspamd, commit 1 is probably the better choice?

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Mar 19, 2024

We should definitely go with f0c222d; there are currently no plans of integrating SA into Rspamd, especially because most of the important rules of SA are already in Rspamd. I currently see no benefit of adding SA to Rspamd.

@casperklein casperklein marked this pull request as ready for review March 20, 2024 19:15
@casperklein casperklein merged commit 3125cad into docker-mailserver:master Mar 20, 2024
@casperklein casperklein deleted the amavis-sa branch March 20, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts kind/bug/fix A fix (PR) for a confirmed bug

Projects

None yet

Milestone

v14.0.0

Development

Successfully merging this pull request may close these issues.

bug report: SA should not send a daily cron error mail when Amavis is disabled

3 participants

@casperklein @georglauterbach @polarathene