Rspamd: minor tweaks and follow-up for SPF, DKIM and DMARC symbols#3923
Merged
georglauterbach merged 4 commits intomasterfrom Mar 5, 2024
Merged
Rspamd: minor tweaks and follow-up for SPF, DKIM and DMARC symbols#3923georglauterbach merged 4 commits intomasterfrom
georglauterbach merged 4 commits intomasterfrom
Conversation
I originally assumed the file had to be placed into `scores.d`, but I now know that `local.d` is actually correct.
See updates to #3690: Additional Rspamd Symbols Rspamd has so-called composite symbols that trigger when a condition is met. Especially AUTH_NA and AUTH_NA_OR_FAIL will adjust the scores of various lines in the table above. This needs to be taken into account.
polarathene
previously approved these changes
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #3913, providing only
Review commit by commit.
composites.confis important because the default policy of these composite symbols I re-defined isremove_weight, which is precisely what we do not want to happen. I noticed this issue only when looking at my Rspamd history recently; I also had to open a bug report over atrspamd/rspamdto find the root cause.Type of change
Checklist
docs/)CHANGELOG.md