Override hostname for kubernetes et al.#390
Closed
iMartyn wants to merge 4 commits intodocker-mailserver:masterfrom
Closed
Override hostname for kubernetes et al.#390iMartyn wants to merge 4 commits intodocker-mailserver:masterfrom
iMartyn wants to merge 4 commits intodocker-mailserver:masterfrom
Conversation
Contributor
|
There is a possibility: v1.PodSpec hostname & subdomain. Please, look here for example. |
Author
|
Hi tyanron, Sure, that's useful, but it doesn't give you the option of returning the dns name. if you set subdomain, it includes the .svc.cluster stuff. I still think that giving the option of specifically using env override is better. |
Closed
Contributor
|
@iMartyn moved to another project. |
Merged
Contributor
|
Moved to #484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In kubernetes land, it's not possible to set the hostname of a container, it's always set to a variation of the pod name, with random characters in it.
This PR should allow the env var OVERRIDE_HOSTNAME to replace the hostname commands that are used in the script.