fix: abort when (jaq) curl fails#3853
Merged
casperklein merged 4 commits intodocker-mailserver:masterfrom Jan 30, 2024
Merged
Conversation
casperklein
changed the title
polarathene
previously approved these changes
Jan 29, 2024
| if [[ ${DOVECOT_COMMUNITY_REPO} -eq 1 ]] && [[ "$(uname --machine)" == "x86_64" ]]; then | ||
| _log 'trace' 'Using Dovecot community repository' | ||
| curl https://repo.dovecot.org/DOVECOT-REPO-GPG | gpg --import | ||
| curl -sSfL https://repo.dovecot.org/DOVECOT-REPO-GPG | gpg --import |
Member
There was a problem hiding this comment.
So a pipe operator won't cause the problem, only && / ||?
Member
Author
There was a problem hiding this comment.
Correct.
Pipes are no problem as we use set -o pipefail. This setting prevents errors in a pipeline from being masked. If any command in a pipeline fails, that return code will be used as the return code of the whole pipeline. By default, the pipeline's return code is that of the last command even if it succeeds.
Member
Author
There was a problem hiding this comment.
PS: Using && the way it was used, makes no sense (no benefit) when set -e is already in place.
polarathene
added
area/scripts
kind/improvement
georglauterbach
previously approved these changes
Jan 29, 2024
casperklein
dismissed stale reviews from georglauterbach and polarathene
via
78723a8
polarathene
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#3852 (comment)
Type of change
Checklist:
docs/)CHANGELOG.md