Skip to content

Rspamd scripts: only correct permissions when directory exists#3849

Merged
georglauterbach merged 1 commit intomasterfrom
rspamd/path-permissions-precondition
Jan 29, 2024
Merged

Rspamd scripts: only correct permissions when directory exists#3849
georglauterbach merged 1 commit intomasterfrom
rspamd/path-permissions-precondition

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

Description

Only fix the permissions on the Rspamd DKIM directory when the directory actually exists. I just updated my deployment and saw

chown: cannot access '/tmp/docker-mailserver/rspamd/dkim': No such file or directory

This PR fixes the issue above.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

Changelog entry not required IMO.

@georglauterbach georglauterbach added this to the v14.0.0 milestone Jan 29, 2024
@georglauterbach georglauterbach self-assigned this Jan 29, 2024
@georglauterbach georglauterbach changed the title only correct permissions when dir exists Rspamd scripts: only correct permissions when directory exists Jan 29, 2024
@georglauterbach georglauterbach enabled auto-merge (squash) January 29, 2024 13:53
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks you beat me to it! 😁 I had realized this needed to be tackled last night 😅

@georglauterbach georglauterbach merged commit 4162d60 into master Jan 29, 2024
@georglauterbach georglauterbach deleted the rspamd/path-permissions-precondition branch January 29, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants