Skip to content

Rspamd: only declare Rspamd variables when not already declared#3837

Merged
georglauterbach merged 3 commits intomasterfrom
rspamd/variables
Jan 26, 2024
Merged

Rspamd: only declare Rspamd variables when not already declared#3837
georglauterbach merged 3 commits intomasterfrom
rspamd/variables

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

Description

Rspamd-related variables are declared with readonly in the corresponding helper. To avoid warnings in the log, we guard on whether they have already been declared.

Fixes an issues raised in #3827

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach georglauterbach added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation service/security/rspamd labels Jan 26, 2024
@georglauterbach georglauterbach added this to the v14.0.0 milestone Jan 26, 2024
@georglauterbach georglauterbach self-assigned this Jan 26, 2024
Comment thread CHANGELOG.md Outdated
@georglauterbach georglauterbach merged commit ba27edc into master Jan 26, 2024
@georglauterbach georglauterbach deleted the rspamd/variables branch January 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation service/security/rspamd

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants