Rspamd: only declare Rspamd variables when not already declared#3837
Merged
georglauterbach merged 3 commits intomasterfrom Jan 26, 2024
Merged
Rspamd: only declare Rspamd variables when not already declared#3837georglauterbach merged 3 commits intomasterfrom
georglauterbach merged 3 commits intomasterfrom
Conversation
12 tasks
polarathene
requested changes
Jan 26, 2024
polarathene
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rspamd-related variables are declared with
readonlyin the corresponding helper. To avoid warnings in the log, we guard on whether they have already been declared.Fixes an issues raised in #3827
Type of change
Checklist:
docs/)CHANGELOG.md