docs(fix): New external link icon workaround for mkdocs-material 9.5.5#3823
Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom Jan 25, 2024
Merged
Conversation
This is the easiest to maintain workaround now available. Upstream continues to reject the value such a feature for accessibility.
georglauterbach
previously approved these changes
Jan 25, 2024
Member
georglauterbach
left a comment
There was a problem hiding this comment.
You will still need to appease the EdirConfig linting gods 🙏🏼🙏🏼🙏🏼
polarathene
commented
Jan 25, 2024
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: b11f406 |
georglauterbach
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the easiest to maintain workaround now available. Upstream continues to reject the value such a feature for accessibility.
Approaches evaluated:
mkdocs.ymlfile gets some raw HTML included into the two external nav links, this just adds a span element to include aclassof our own that we can reference in CSS.Fixes #3822
Another alternative that was suggested by the primary mkdocs-material dev is to disable Instant Navigation feature, since that is what broke our current CSS by removing the relative URLs at runtime on the client (browser).
Type of change
Checklist:
CHANGELOG.mdI don't think this needs a changelog entry?