fix: Ensure correct ownership for the Rspamd DKIM directory#3813
Merged
georglauterbach merged 1 commit intomasterfrom Jan 23, 2024
Merged
Conversation
The UID / GID shifted during a new release. Until DKIM handling is refactored in a new major release, this fix ensures the content maintains the expected `_rspamd` ownership.
polarathene
added
area/scripts
service/security/dkim-dmarc-spf
service/security/rspamd
kind/bug/fix
georglauterbach
approved these changes
Jan 23, 2024
georglauterbach
deleted the
fix/ensure-correct-ownership-for-rspamd-dkim-dir
branch
Member
|
I will adjust the changelog with the v13.3.1 PR to account for this. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applies the suggested fix from reporter: #3800 (comment)
_rspamdownership.Fixes #3800
OpenDKIM recently had a contribution for ownership adjustment, although that was for the user benefit with config volume files, not an issue with DMS support.
Ownership issues in
/tmp/docker-mailservershouldn't matter or need to be fixed for DMS, but the present rspamd DKIM support has a rather relaxed / flexible location where it's associated config points to the files instead of a local internal copy made at runtime.NOTE: There is already related script for rspamd during startup that attempts to get DKIM keys to inspect by parsing
pathsettings indkim_signing.conf, logging warnings when the ownership is not_rspamd.Type of change
Checklist:
CHANGELOG.md