fix: Correctly support multiple Dovecot PassDBs#3812
Merged
georglauterbach merged 4 commits intodocker-mailserver:masterfrom Jan 23, 2024
Merged
Conversation
This prevents PassDBs incompatible with certain auth mechanisms from logging failures which accidentally triggers Fail2Ban. Instead only allow the PassDB to be authenticated against when it's compatible with the auth mechanism used.
`curl` provides this capability for both IMAP and SMTP authentication with a bearer token. It supports both `XOAUTH2` and `OAUTHBEARER` mechanisms, as these updated test-cases demonstrate.
72c7f88 to
1293591
Compare
georglauterbach
approved these changes
Jan 23, 2024
Member
georglauterbach
left a comment
There was a problem hiding this comment.
LGTM 👍 When 13.3.1 is out, I will rebase my sending-filtering-in-tests-PR to update the helpers.
casperklein
approved these changes
Jan 23, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented fix as proposed at: #3801 (comment)
curlfor IMAP Auth test as well)plain loginis used since this is intended for a bug fix release. In future we should probably droploginsupport.fix: Dovecot PassDB should restrict allowed auth mechanisms:
tests: Use
curlfor OAuth2 login test-cases instead of netcat:curlprovides this capability for both IMAP and SMTP authentication with a bearer token. It supports bothXOAUTH2andOAUTHBEARERmechanisms, as these updated test-cases demonstrate.Fixes #3801
Type of change
Checklist:
CHANGELOG.md