Skip to content

Fix jaq: Download platform specific binary#3766

Merged
polarathene merged 3 commits intodocker-mailserver:masterfrom
casperklein:fix-3764
Jan 9, 2024
Merged

Fix jaq: Download platform specific binary#3766
polarathene merged 3 commits intodocker-mailserver:masterfrom
casperklein:fix-3764

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Jan 9, 2024 •
edited
Loading

Description

Fixes #3764

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@casperklein casperklein self-assigned this Jan 9, 2024
@casperklein casperklein added the kind/bug/fix A fix (PR) for a confirmed bug label Jan 9, 2024
@casperklein casperklein added this to the v14.0.0 milestone Jan 9, 2024
@casperklein casperklein marked this pull request as ready for review January 9, 2024 15:53
@polarathene polarathene merged commit aba218e into docker-mailserver:master Jan 9, 2024
@polarathene
Copy link
Copy Markdown
Member

polarathene commented Jan 9, 2024

I'm not 100% sure how well this works or will continue to work.

uname -m depends on the kernel, but this isn't always accurate with cross-platform builds (those that run on x86_64 but build for aarch64). We're using QEMU for the ARM64 build but I do recall reading somewhere (fairly sure it was related to Docker) that there was a way to support building where uname -m would provide x86_64 and instead you'd need to rely on build context env 🤔

Just chiming in with this in case that does happen (now or in future due to upstream changes).

@georglauterbach georglauterbach modified the milestones: v14.0.0, v13.3.0 Jan 15, 2024
@casperklein casperklein deleted the fix-3764 branch January 30, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

kind/bug/fix A fix (PR) for a confirmed bug

Projects

None yet

Milestone

v13.3.0

Development

Successfully merging this pull request may close these issues.

bug report: /usr/bin/jaq - binary format error (image uses x86 binary for arm installation)

3 participants

@casperklein @polarathene @georglauterbach