Skip to content

Rspamd: add custom symbol scores for SPF, DKIM & DMARC#3726

Merged
georglauterbach merged 2 commits intomasterfrom
rspamd/rfc7489
Jan 5, 2024
Merged

Rspamd: add custom symbol scores for SPF, DKIM & DMARC#3726
georglauterbach merged 2 commits intomasterfrom
rspamd/rfc7489

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Dec 27, 2023 •
edited
Loading

Description

This PR adjusts Rspamd's symbol scores to better align with RFC7489, see #3690.

Closes #3690

Type of change

  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • This change requires a documentation update (does it?)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach georglauterbach added kind/update Update an existing feature, configuration file or the documentation service/security/rspamd labels Dec 27, 2023
@georglauterbach georglauterbach added this to the v14.0.0 milestone Dec 27, 2023
@georglauterbach georglauterbach self-assigned this Dec 27, 2023
@georglauterbach georglauterbach marked this pull request as draft December 27, 2023 17:56
polarathene
polarathene previously approved these changes Dec 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to give a proper review as rspamd config here is not something I'm familiar with or have time to get acquainted with 😓

General review feedback though, no concerns 👍

@georglauterbach georglauterbach changed the title Rspamd: add custom symbol scores for SPF, DKIM & DMARC to Rspamd Rspamd: add custom symbol scores for SPF, DKIM & DMARC Jan 2, 2024
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Jan 4, 2024

Rebased on master and added a changelog entry.

@georglauterbach georglauterbach marked this pull request as ready for review January 4, 2024 21:25
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Jan 4, 2024

@ap-wtioit @Nebucatnetzer could you give this PR a short look please?:) Better to have another 2 pairs of eyes on this change. It's not too big and not too impactful, but safe is safe.

@Nebucatnetzer
Copy link
Copy Markdown

Nebucatnetzer commented Jan 4, 2024

I have the actions and the policies running since a few days and haven’t noticed anything off yet.
I noticed that the spam mails now get their subject changed which worked great with a sieves adjustment.
However I’m not really an expert with rspamd :).

polarathene
polarathene approved these changes Jan 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with the same context as my earlier approval) 👍

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Jan 5, 2024

I have the actions and the policies running since a few days and haven’t noticed anything off yet.

👍🏼

I noticed that the spam mails now get their subject changed which worked great with a sieves adjustment.

Perfect, that's exactly what ought to happen 🚀 Rejections should only happen when the anti-spam software is absolutely sure it is safe to reject, so the behaviour you're seeing is perfect 👍🏼

If you want to go one step further still, you can think about using Abusix. We have a documentation entry for that already.

@georglauterbach georglauterbach merged commit 04f4ae4 into master Jan 5, 2024
@georglauterbach georglauterbach deleted the rspamd/rfc7489 branch January 5, 2024 08:07
georglauterbach added a commit that referenced this pull request Jan 5, 2024
@georglauterbach
Rspamd: add custom symbol scores for SPF, DKIM & DMARC (#3726)
71a5a2a
georglauterbach added a commit that referenced this pull request Jan 6, 2024
@georglauterbach
Revert "Rspamd: add custom symbol scores for SPF, DKIM & DMARC (#3726)"
198a5e7 
This reverts commit 71a5a2a.
@georglauterbach georglauterbach modified the milestones: v14.0.0, v13.3.0 Jan 15, 2024
This was referenced Feb 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels

kind/update Update an existing feature, configuration file or the documentation service/security/rspamd

Projects

Rspamd Integration
Archived in project

Milestone

v13.3.0

Development

Successfully merging this pull request may close these issues.

Rspamd: provide RFC7489 compliance for SPF, DKIM & DMARC

4 participants

@georglauterbach @Nebucatnetzer @casperklein @polarathene