Skip to content

docs: update CONTRIBUTORS.md#3704

Merged
casperklein merged 3 commits intomasterfrom
contributors-readme-action-IpJ1V66ask
Dec 19, 2023
Merged

docs: update CONTRIBUTORS.md#3704
casperklein merged 3 commits intomasterfrom
contributors-readme-action-IpJ1V66ask

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

No description provided.

@casperklein casperklein enabled auto-merge (squash) December 17, 2023 11:14
@casperklein
Copy link
Copy Markdown
Member

grafik

Lint check is required but not running?

@polarathene
Copy link
Copy Markdown
Member

Lint check is required but not running?

Yeah, it's not listed in the workflow history as triggered at all 🤷‍♂️

I've opened a PR to try resolve it by skipping the requirement for these automated PRs, assuming that condition doesn't require a trigger first 😅

@georglauterbach
Copy link
Copy Markdown
Member

The lint workflows is required (in the repository settings), hence GitHub lists it here. But because one action must not trigger other actions in new PRs, the linting action is not actually running.

@polarathene
Copy link
Copy Markdown
Member

But because one action must not trigger other actions in new PRs, the linting action is not actually running

Ah I see, in the history of these PRs you're often merging them directly (since you have that ability), otherwise it waits until the branch can be updated with newer changes from master which allows another maintainer to merge since that triggers the lint workflow 😵

Skipping the workflow trigger won't help then? 😕

@polarathene
Copy link
Copy Markdown
Member

Ok, so updating the branch with merge commit that contains the ignore rule for CONTRIBUTORS.md has prevented the check from running 🙄

My bad, I'll revert that since this is even worse 🤣

@casperklein casperklein merged commit 6a56c7e into master Dec 19, 2023
@casperklein casperklein deleted the contributors-readme-action-IpJ1V66ask branch December 19, 2023 06:01
reneploetz pushed a commit to reneploetz/docker-mailserver that referenced this pull request Dec 20, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants