Skip to content

Add ENV ENABLE_IMAP#3703

Merged
casperklein merged 6 commits intodocker-mailserver:masterfrom
casperklein:enable_imap
Dec 18, 2023
Merged

Add ENV ENABLE_IMAP#3703
casperklein merged 6 commits intodocker-mailserver:masterfrom
casperklein:enable_imap

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Dec 17, 2023 •
edited
Loading

Description

This PR adds the ENV ENABLE_IMAP. Like ENABLE_POP3, this allows to enable/disable IMAP.

In a POP3 only setup, this allows to not start the IMAP service.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@casperklein casperklein self-assigned this Dec 17, 2023
@casperklein casperklein added kind/new feature A new feature is requested in this issue or implemeted with this PR area/scripts labels Dec 17, 2023
@casperklein casperklein added this to the v13.1.0 milestone Dec 17, 2023
@casperklein casperklein marked this pull request as ready for review December 17, 2023 00:15
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Dec 17, 2023

This test failed: https://github.com/docker-mailserver/docker-mailserver/actions/runs/7235052163/job/19712079567

Re-running the test was successful.

polarathene
polarathene requested changes Dec 17, 2023
View reviewed changes
Comment thread CHANGELOG.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 17, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: ba1c1da

@casperklein casperklein mentioned this pull request Dec 17, 2023
Closed
1 task
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Dec 18, 2023

Are ENABLE_POP3 and ENABLE_IMAP both zero or both one valid configurations?

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Dec 18, 2023

Yes. Like most other ENVs, the values are only checked if equal 1 to enable it. All other values are considered to disable it. I haven't changed the logic, only streamlined the docs.

georglauterbach
georglauterbach approved these changes Dec 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@casperklein casperklein merged commit 98a4c13 into docker-mailserver:master Dec 18, 2023
@casperklein casperklein deleted the enable_imap branch December 18, 2023 11:26
reneploetz pushed a commit to reneploetz/docker-mailserver that referenced this pull request Dec 20, 2023
@casperklein @reneploetz
Add ENV ENABLE_IMAP (docker-mailserver#3703)
e2d1868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts kind/new feature A new feature is requested in this issue or implemeted with this PR service/dovecot

Projects

None yet

Milestone

v13.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @georglauterbach @polarathene