Skip to content

fix: only set virtual_mailbox_maps to texthash when not using LDAP#3693

Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom
reneploetz:3692-fix-ldap-integration
Dec 10, 2023
Merged

fix: only set virtual_mailbox_maps to texthash when not using LDAP#3693
polarathene merged 2 commits intodocker-mailserver:masterfrom
reneploetz:3692-fix-ldap-integration

Conversation

@reneploetz
Copy link
Copy Markdown
Contributor

@reneploetz reneploetz commented Dec 10, 2023

Fixes #3692

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@reneploetz
Copy link
Copy Markdown
Contributor Author

reneploetz commented Dec 10, 2023 •
edited
Loading

Note that one could think about moving the comment into the condition so that comment and change are closer to each other. I just opted for the smallest change here.

@georglauterbach georglauterbach added this to the v13.1.0 milestone Dec 10, 2023
@georglauterbach georglauterbach changed the title Only set virtual_mailbox_maps to texthash when using the FILE account… LDAP: only set virtual_mailbox_maps to texthash when not using LDAP Dec 10, 2023
polarathene
polarathene approved these changes Dec 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, sorry about the bug! 😬

@polarathene polarathene changed the title LDAP: only set virtual_mailbox_maps to texthash when not using LDAP fix: only set virtual_mailbox_maps to texthash when not using LDAP Dec 10, 2023
@polarathene polarathene merged commit 2f5dfed into docker-mailserver:master Dec 10, 2023
reneploetz added a commit to reneploetz/docker-mailserver that referenced this pull request Dec 20, 2023
@reneploetz
fix: Only set virtual_mailbox_maps to texthash when using the `FI…
4ead1c2 
…LE` account provisioner (docker-mailserver#3693)

Signed-off-by: René Plötz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@reneploetz reneploetz

Labels

area/scripts kind/bug/fix A fix (PR) for a confirmed bug service/ldap

Projects

None yet

Milestone

v13.1.0

Development

Successfully merging this pull request may close these issues.

LDAP integration is broken in current edge

4 participants

@reneploetz @casperklein @polarathene @georglauterbach