ci: Linter EC should use /check as the mount path#3655
Merged
casperklein merged 2 commits intomasterfrom Nov 25, 2023
Merged
Conversation
This internal container path has been allowed as an exception for `git` to avoid a safety check that would otherwise fail EC detection for `git` support path.
polarathene
added
area/ci
kind/update
georglauterbach
approved these changes
Nov 25, 2023
casperklein
approved these changes
Nov 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This internal container path of the image has been allowed as an exception for
gitto avoid a safety check, that would otherwise cause EC to fail detection forgit, triggering fallback logic.This shouldn't have any real impact on our CI, which already has an explicit ignore for
.git/. Just a change to better align with upstream documentation and include some context via comments for maintainers 👍