Skip to content

docs: Example - Integrating Crowdsec#3651

Merged
georglauterbach merged 2 commits intodocker-mailserver:masterfrom
mivek:docs-crowdsec
Nov 25, 2023
Merged

docs: Example - Integrating Crowdsec#3651
georglauterbach merged 2 commits intodocker-mailserver:masterfrom
mivek:docs-crowdsec

Conversation

@mivek
Copy link
Copy Markdown
Contributor

@mivek mivek commented Nov 22, 2023

Description

I added a page explaining how to use crowdsec with docker-mailserver.
The page is not a complete tutorial on how to install and configure crowdsec but covers the docker-mailserver logs parsing by crowdsec.

I added the page under examples/tutorials

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)

polarathene
polarathene requested changes Nov 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I also really like how you've leveraged the admonition types and respected out link conventions ❤️

Some typos to address and minor revisions, but otherwise great work! 😎

We are looking at bringing Vector into DMS at some point to improve our logging support. You may want to subscribe to that issue in the event your guide here needs to be adjusted.

Comment thread docs/content/examples/tutorials/crowdsec.md Outdated
Comment thread docs/content/examples/tutorials/crowdsec.md Outdated
Comment thread docs/content/examples/tutorials/crowdsec.md Outdated
Comment thread docs/content/examples/tutorials/crowdsec.md Outdated
Comment thread docs/content/examples/tutorials/crowdsec.md Outdated
Comment thread docs/mkdocs.yml Outdated
@polarathene polarathene added this to the v13.1.0 milestone Nov 22, 2023
@mivek
Copy link
Copy Markdown
Contributor Author

mivek commented Nov 23, 2023

Thank you @polarathene for you feedback, I applied the suggested changes.

I will squash the commits when the PR is approved.

polarathene
polarathene reviewed Nov 23, 2023
View reviewed changes
Comment thread docs/content/examples/tutorials/crowdsec.md Outdated
polarathene
polarathene approved these changes Nov 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@georglauterbach do you want to squeeze this into the v13 release or defer to v13.1?

@polarathene polarathene changed the title Docs: Crowdsec integration docs: Example - Integrating Crowdsec Nov 23, 2023
@polarathene polarathene mentioned this pull request Nov 25, 2023
Merged
4 tasks
@georglauterbach georglauterbach modified the milestones: v13.1.0, v13.0.0 Nov 25, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 25, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: 999bf37

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Nov 25, 2023

Squashing this and #3654 into v13.0.0 no problem 🚀

@georglauterbach georglauterbach merged commit cedd360 into docker-mailserver:master Nov 25, 2023
@mivek mivek deleted the docs-crowdsec branch November 25, 2023 14:04
@williamdes
Copy link
Copy Markdown
Contributor

williamdes commented Dec 8, 2023 •
edited
Loading

You might be interested in https://github.com/datacenters-network/mails/tree/main/crowdsec/parsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

Assignees

@mivek mivek

Labels

area/documentation

Projects

None yet

Milestone

v13.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mivek @georglauterbach @williamdes @casperklein @polarathene