tests(fix): Run pgrep within the actual container#3553
Merged
georglauterbach merged 1 commit intomasterfrom Sep 28, 2023
Merged
tests(fix): Run pgrep within the actual container#3553georglauterbach merged 1 commit intomasterfrom
pgrep within the actual container#3553georglauterbach merged 1 commit intomasterfrom
Conversation
…ual container This was missed during original review. On a linux host, processes running within a container have been visible via commands like `pgrep`. This is does not appear to be the case with WSL2 + Docker Desktop (Windows), resulting in test failure. The command should have been run from within the container regardless.
polarathene
added
area/tests
service/fetchmail
kind/bug/fix
georglauterbach
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was missed during the original review of #3010
On a linux host, processes running within a container have been visible via commands like
pgrep. This is does not appear to be the case with WSL2 + Docker Desktop (Windows), resulting in test failure.The command should have been run from within the container regardless.
Type of change