Skip to content

fix: Open-DKIM key generation broken#3535

Merged
georglauterbach merged 3 commits intodocker-mailserver:masterfrom
luke-:patch-1
Sep 13, 2023
Merged

fix: Open-DKIM key generation broken#3535
georglauterbach merged 3 commits intodocker-mailserver:masterfrom
luke-:patch-1

Conversation

@luke-
Copy link
Copy Markdown
Contributor

@luke- luke- commented Sep 12, 2023 •
edited
Loading

With ENABLE_OPENDKIM=1 and ENABLE_RSPAMD=1 it's currently not possible to create DKIM Keys

Description

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@luke-
fix: Open-DKIM key generation broken
f6d64da 
With `ENABLE_OPENDKIM=1` and `ENABLE_RSPAMD=1` it's currently not possible to create DKIM Keys
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Sep 12, 2023

Good observation! I'd actually like to error-out in a fail-fast way. This patch would hide a misconfiguration. I will add a suggestion.

georglauterbach
georglauterbach requested changes Sep 12, 2023
View reviewed changes
Comment thread target/bin/open-dkim Outdated
@georglauterbach georglauterbach self-requested a review September 12, 2023 22:53
@georglauterbach georglauterbach added this to the v13.0.0 milestone Sep 12, 2023
@luke- @georglauterbach
Update target/bin/open-dkim
03451f6 
Co-authored-by: Georg Lauterbach <[email protected]>
@luke-
Copy link
Copy Markdown
Contributor Author

luke- commented Sep 12, 2023

@georglauterbach Thanks, just merged your suggestion.
Fyi: Not tested it. I'm not a bash scripting pro. Is there a fi missing?

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Sep 13, 2023

@georglauterbach Thanks, just merged your suggestion.

Fyi: Not tested it. I'm not a bash scripting pro. Is there a fi missing?

There is 😂 Good observation!

@luke-
Copy link
Copy Markdown
Contributor Author

luke- commented Sep 13, 2023

Ok, I've fixed and tested it.

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Sep 13, 2023

Tests running now. I'll merge when all tests check out.

@georglauterbach georglauterbach merged commit 86edaf9 into docker-mailserver:master Sep 13, 2023
@luke- luke- deleted the patch-1 branch September 13, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@luke- luke-

Labels

area/scripts kind/bug/fix A fix (PR) for a confirmed bug service/security/rspamd

Projects

Rspamd Integration
Archived in project

Milestone

v13.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@luke- @georglauterbach