Skip to content

tests: Revise LDAP config + setup#3514

Merged
polarathene merged 5 commits intodocker-mailserver:masterfrom
polarathene:tests/ldap-revise-config
Aug 29, 2023
Merged

tests: Revise LDAP config + setup#3514
polarathene merged 5 commits intodocker-mailserver:masterfrom
polarathene:tests/ldap-revise-config

Conversation

@polarathene
Copy link
Copy Markdown
Member

@polarathene polarathene commented Aug 29, 2023

Description

Minor changes to LDAP test:

  • Revised the query filters and inlined heavy docs for maintainers benefit. Future changes should migrate most of this to the user docs.
  • Added a test-case specific container example for an existing LDAP PR to reference. This is a bit more complicated for the LDAP test file with our current test format, as the extra args is large in size and uses variables. They could be hoisted out of setup() or better addressed once migrating to compose.yaml for container config setup.
  • The test has its own config folder used with volume mounts / mv. Nothing notable to these changes beyond housekeeping.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@polarathene
chore: Use white-space in query filters to improve readability
029b120
@polarathene
tests: LDAP ENV query filters documented
9c37f36 
- These filters remain roughly the same as they were before. The conditions are the same, but restructured to make the complimentary constraints more separated from the actual target attribtues.
- The DOMAIN query additionally includes the `mailAlias` from `PostfixBookMailAccount` class as well.
- Heavy inline documentation breaking down how the filters work for any maintainer to reference. This will likely be migrated after revision into our user docs for LDAP. Some quirks have also been noted with advice for future changes.
@polarathene
tests: LDAP - Support test-case specific containers
68b44e7 
A bit more complicated than other test files due to the larger ENV config array that most containers may need to share.

Example introduced with the test-case checking custom config file support.
@polarathene
tests: Adjust LDAP test configs
6f627e7 
- Paths for `.ldif` files used with volumes shortened
- Postfix LDAP `.cf` files adjusted to conventions used in LDAP tests.
@polarathene polarathene added area/tests service/ldap kind/update Update an existing feature, configuration file or the documentation labels Aug 29, 2023
@polarathene polarathene added this to the v13.0.0 milestone Aug 29, 2023
@polarathene polarathene self-assigned this Aug 29, 2023
@polarathene polarathene mentioned this pull request Aug 29, 2023
Closed
11 tasks
@williamdes
Copy link
Copy Markdown
Contributor

williamdes commented Aug 29, 2023

Thanks

georglauterbach
georglauterbach approved these changes Aug 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@polarathene polarathene merged commit e025e4c into docker-mailserver:master Aug 29, 2023
@polarathene polarathene mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georglauterbach georglauterbach georglauterbach approved these changes

@casperklein casperklein Awaiting requested review from casperklein

Assignees

@polarathene polarathene

Labels

area/tests kind/update Update an existing feature, configuration file or the documentation service/ldap

Projects

None yet

Milestone

v13.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@polarathene @williamdes @georglauterbach