chore: Adapt ENABLE_LDAP=1 to ACCOUNT_PROVISIONER=LDAP#3507
Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom Aug 28, 2023
Merged
Conversation
- Deprecation startup script check is kept for `ENABLE_LDAP=1` but adjusted to emit an error instead. It can be dropped in a future release. Just a precaution for those who mistakenly update (_possibly via automation_) without checking the release notes, an error log is somewhat helpful, although it could alternatively panic? - Docs updated to remove the `ENABLE_LDAP=1` usage - ENV docs updated to reference a maintained LDAP image. - Changelog includes the breaking change, and slight revision to prior release mention of deprecation.
polarathene
added
service/ldap
area/configuration (file)
kind/update
georglauterbach
approved these changes
Aug 28, 2023
casperklein
approved these changes
Aug 28, 2023
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: 403ee80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before we forget and release v13 😅
ENABLE_LDAP=1but adjusted to emit an error instead. It can be dropped in a future release. Just a precaution for those who mistakenly update (possibly via automation) without checking the release notes, an error log is somewhat helpful, although it could alternatively panic?ENABLE_LDAP=1usage