Description

Another iterative change for LDAP test.

I could stage these out in a multi-commit PR but I'm choosing to preserve some change history and provide smaller diff for review, before introducing a change for v13 (outside of the tests, but will also affect this LDAP test going forward).

No change to DMS beyond the LDAP test and it's test data.

Changes:

• The uniqueIdentifier attribute is not appropriate and was relying on objectClass: extensibleObject as a workaround to allow it. A more appropriate attribute to use instead is userID (short name: uid).
• Removing extensibleObject now requires switching the user accounts to use inetOrgPerson class (which inherits from organizationalPerson). which allows the attributes givenName, userID and mail (also provided via the PostfixBookMailAccount class).
• The LDAP root object now uses dc attributes for example.test instead of localhost.localdomain. This has nothing to do with DMS or LDAP containers networking config, nor the users mail addresses.
• Users are now grouped under the organizational unit of users instead of people. Purely a naming change out of preference, no functional difference.

The LDAP test ENV has been updated to accommodate the above changes. An additional ENV override was required for SASLAuthd to switch an attribute set for ldap_filter in /etc/saslauthd.conf from the implicit default of uniqueIdentifier (that we set during startup as an ENV default for fallback) to the userID attribute.

Relevant history:

• uniqueIdentifier was introduce into DMS via the original LDAP support PR Add ldap auth for postfix and dovecot #352 but lacks information on the choice (that PR was another attempt building off from the work in Added features: saslauthd-ldap support, postfix-ldap support, postfix… #335 ). There is no mention of this attribute in LDAP docs for SASLAuthd, Dovecot, or Postfix.
• The change to using userID as part of the LDAP DN for users and thus the lookup query filters may have a slight impact on test-cases for LDAP spoofing (SPOOF_PROTECTION=1), as the ldap-senders.cf file (contributed by Add LDAP_QUERY_FILTER_SENDERS setting for spoof protection with LDAP #1902 ) has a result_attribute value of mail, uid, returning the userID attribute which now exists in the LDIF test data. However, those test cases need some rework anyway 😅

Type of change

• Improvement (non-breaking change that does improve existing functionality)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• New and existing unit tests pass locally with my changes