scripts: add wrapper to update Postfix configuration safely (follow up)#3503
Merged
casperklein merged 14 commits intodocker-mailserver:masterfrom Aug 27, 2023
Merged
scripts: add wrapper to update Postfix configuration safely (follow up)#3503casperklein merged 14 commits intodocker-mailserver:masterfrom
casperklein merged 14 commits intodocker-mailserver:masterfrom
Conversation
9 tasks
casperklein
commented
Aug 26, 2023
polarathene
previously approved these changes
Aug 26, 2023
Member
polarathene
left a comment
There was a problem hiding this comment.
Nice improvement! 😁
This is much simpler to grok now without all the sed syntax dance and escaping added into the mix.
polarathene
reviewed
Aug 26, 2023
georglauterbach
previously approved these changes
Aug 27, 2023
Member
georglauterbach
left a comment
There was a problem hiding this comment.
Not blocking on the check, but it'd be nice to see [[ rather than grep.
polarathene
previously approved these changes
Aug 27, 2023
b85fd0a
polarathene
approved these changes
Aug 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on improving the function
_add_to_or_update_postfix_main(), I noticed a problem we had before in other occasions.SED_STRING="/${NEW_VALUE}/!This is not really fail safe, when
$NEW_VALUEis a substring of an existing value.Now I simplified the whole function, by replacing
sedwithpostconf.Fixes #3484
Type of change
Checklist:
docs/)