feat: Allow marking spam as read via a sieve filter (ENV MARK_SPAM_AS_READ=1)#3489
Merged
polarathene merged 3 commits intodocker-mailserver:masterfrom Aug 20, 2023
Merged
Conversation
polarathene
requested changes
Aug 20, 2023
Member
There was a problem hiding this comment.
Thanks for the contribution! 😁
Good work, just some changes to apply:
- Remove some lines that aren't necessary.
- Revised ENV docs entry.
- Slight context on the two spam header sources, co-located beside the sieve script being created.
- Test should use it's own container name since you're creating a new container instance (in parallel test set)
- Test should be solving the reference issue justifying the feature, that for some reason spam being delivered to junk mail was triggering new mail delivery notification to the mail client. Unless there's a reason to want to deliver spam to main inbox, and mark it as read (still supported, but not what the reference issue expressed as a problem).
- Changelog revised slightly, references this PR as other changelog items can be seen to do.
polarathene
added
kind/new feature
Co-authored-by: Brennan Kinney <[email protected]>
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: b14d7fd |
georglauterbach
approved these changes
Aug 20, 2023
Member
georglauterbach
left a comment
georglauterbach
left a comment
There was a problem hiding this comment.
Looks really good! Thank your for your contribution ❤️ 🚀
polarathene
approved these changes
Aug 20, 2023
Member
polarathene
left a comment
polarathene
left a comment
There was a problem hiding this comment.
Fantastic work! 💪
LGTM :)
polarathene
changed the title
MARK_SPAM_AS_READ=1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added environment variable
MARK_SPAM_AS_READwhich allows to automatically mark spam mails as read to prevent notifications about them.Closes #3449
Type of change
Checklist:
docs/)