Skip to content

feat(setup): Add fail2ban sub-command status <JAIL>#3455

Merged
polarathene merged 3 commits intodocker-mailserver:masterfrom
nilshoell:master
Aug 2, 2023
Merged

feat(setup): Add fail2ban sub-command status <JAIL>#3455
polarathene merged 3 commits intodocker-mailserver:masterfrom
nilshoell:master

Conversation

@nilshoell
Copy link
Copy Markdown
Contributor

Description

This PR adds a new option to the setup.sh fail2ban script to show a more detailed view on the status of all fail2ban jails using fail2ban's native status <jail> command. Effectively, the options just runs exactly that command for all jails already existing in the JAILS variable and outputs the result.
I wanted to have an option between just running the setup fail2ban sub-command without options that just returns the banned IPs and getting all details using setup fail2ban log.
This might be a bit redundant to other options, but since it is a small change that breaks nothing, I figured I could move it back here, since its usage is probably very intuitive to any fail2ban user.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Comment thread target/bin/fail2ban Outdated
Comment thread docs/content/config/security/fail2ban.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: a3ed3f0

Copy link
Copy Markdown
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

@polarathene polarathene changed the title fail2ban: add status sub-command for the fail2ban script feat(setup): Add fail2ban sub-command status <JAIL> Aug 2, 2023
@polarathene polarathene merged commit 8560319 into docker-mailserver:master Aug 2, 2023
@polarathene polarathene added area/scripts service/security/fail2ban area/features kind/improvement Improve an existing feature, configuration file or the documentation labels Aug 2, 2023
@polarathene polarathene added this to the v13.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/features area/scripts kind/improvement Improve an existing feature, configuration file or the documentation service/security/fail2ban

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants